Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e-mail styles and wrapper #2672

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Update e-mail styles and wrapper #2672

merged 4 commits into from
Dec 14, 2023

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Dec 7, 2023 •
edited by github-actions bot
Loading

Part of 396-gh-Automattic/wpjm-addons

Changes Proposed in this Pull Request

  • Update the e-mail header and footer with new layout built for Alert e-mails
  • Fix font family not working in e-mails
  • Update styling

Testing Instructions

  • Set up mail capture / a way to view outgoing e-mails
  • Make sure e-mails are enabled and set to rich text in Job Manager -> Settings -> E-mail Notifications
  • Do an action that triggers an e-mail: submit a new job on the frontend, edit a job on the frontend, submit a resume
  • View the e-mail

Release Notes

  • Change: Improve styling for rich text e-mails

Screenshot / Video

image
Plugin build for 9a06455
📦 Download plugin zip
▶️ Open in playground

@yscik yscik requested a review from a team December 7, 2023 17:05
@yscik yscik self-assigned this Dec 7, 2023
thedebian
thedebian reviewed Dec 12, 2023
View reviewed changes
templates/emails/email-styles.php Outdated
@@ -11,25 +11,28 @@
* @version 1.31.0
*/

if ( ! defined( 'ABSPATH' ) ) {
if ( ! defined( "ABSPATH" ) ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change all single quotes in the file to double-quotes ?
Usually it's always single quotes, except if you need to interpret a var in the string, but maybe there's a reason here ? (I think it might just be something your IDE did by itself)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops that might have been a find-n-replace gone wrong

templates/emails/email-styles.php Outdated Show resolved Hide resolved
templates/emails/email-styles.php Outdated Show resolved Hide resolved
thedebian
thedebian suggested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@thedebian thedebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as advertised, requesting changes for the code comments, apart from that 🚀

@yscik
Copy link
Contributor Author

yscik commented Dec 13, 2023

Beautified in 9a06455

@yscik yscik merged commit 9579c71 into trunk Dec 14, 2023
8 checks passed
@yscik yscik deleted the change/email-template branch December 14, 2023 12:40
@yscik yscik added this to the 2.2.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedebian thedebian thedebian requested changes

Assignees

@yscik yscik

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yscik @thedebian